Drive/k8s-manifests
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

testing just using an emptyDir for rendered config (+more) #1

Merged
lasse merged 5 commits from richir-more-labb into main 2025-02-18 08:11:38 +00:00
Conversation 2 Commits 5 Files changed 29 +729 -725
richir commented 2025-02-14 12:48:07 +00:00
Owner
Copy link

OBS. hemligheterna för vinnova och nordunet måste struktureras enligt ENV: hemlis i nextcloud-secrets innan denna merge:as.

OBS. hemligheterna för vinnova och nordunet måste struktureras enligt `ENV: hemlis` i `nextcloud-secrets` innan denna merge:as.
richir added 1 commit 2025-02-14 12:48:07 +00:00
Micke reviewed 2025-02-14 12:51:26 +00:00
Micke left a comment
Owner
Copy link

Should we have application.yaml in applications for vinnova and nordunet too?

Should we have application.yaml in applications for vinnova and nordunet too?
Micke approved these changes 2025-02-14 12:52:06 +00:00
richir commented 2025-02-14 13:25:10 +00:00
Author
Owner
Copy link

@Micke wrote in #1 (comment):

Should we have application.yaml in applications for vinnova and nordunet too?

I think we remove the Application and generate them all from an ApplicationSet

@Micke wrote in https://platform.sunet.se/Drive/k8s-manifests/pulls/1#issuecomment-1758: > Should we have application.yaml in applications for vinnova and nordunet too? I think we remove the `Application` and generate them all from an `ApplicationSet`
👍 1
lasse commented 2025-02-16 15:43:00 +00:00
Owner
Copy link

Looks good. It might be nice to use configMapGenerator in kustomization.yml for apache and Nextcloud configmaps, but we can do that later. It makes it a bit cleaner imo since you can keep the actual php and apache configfiles as they are, instead of big inline blobs in yaml.

Looks good. It might be nice to use configMapGenerator in kustomization.yml for apache and Nextcloud configmaps, but we can do that later. It makes it a bit cleaner imo since you can keep the actual php and apache configfiles as they are, instead of big inline blobs in yaml.
lasse approved these changes 2025-02-16 15:43:24 +00:00
lasse added 1 commit 2025-02-17 09:29:40 +00:00
lasse force-pushed richir-more-labb from 577940044c to f01ec30d64 2025-02-17 09:37:55 +00:00 Compare
Micke requested changes 2025-02-17 10:30:00 +00:00
Micke left a comment
Owner
Copy link

I have one comment and one question :)

I have one comment and one question :)
customers/base/files/config.php
@ -0,0 +35,4 @@
'gs.enabled' => 'true',
'gs.federation' => 'global',
'gs.trustedHosts' => ['*.sunet.se'],
'gss.jwt.key' => '{{GSS_JWT_KEY}}',
Micke commented 2025-02-17 10:27:10 +00:00
Owner
Copy link

gss.* are old settings that we want to remove

gss.* are old settings that we want to remove
Micke commented 2025-02-18 08:01:01 +00:00
Owner
Copy link

Fixed in #a260fed464aa6c268151226c99ed1d9ae0805934

Fixed in #a260fed464aa6c268151226c99ed1d9ae0805934
Micke marked this conversation as resolved
customers/base/nextcloud-deployment.yml
@ -31,3 +37,3 @@
containers:
- name: customer
image: docker.sunet.se/drive/nextcloud-custom:30.0.5.2-2
image: nextcloud-custom-image
Micke commented 2025-02-17 10:28:44 +00:00
Owner
Copy link

What image is this?

What image is this?
Micke commented 2025-02-18 07:59:05 +00:00
Owner
Copy link

Found it! It is defined in kustomization.yaml

images:
  - name: nextcloud-custom-image
    newName: docker.sunet.se/drive/nextcloud-custom
    newTag: 30.0.5.2-2
Found it! It is defined in kustomization.yaml ``` images: - name: nextcloud-custom-image newName: docker.sunet.se/drive/nextcloud-custom newTag: 30.0.5.2-2 ```
Micke marked this conversation as resolved
lasse reviewed 2025-02-17 10:54:35 +00:00
customers/overlays/nordunet/test/kustomization.yaml Outdated
@ -8,0 +6,4 @@
- path: env-configmap.yml
- path: nextcloud-deployment.yml
- path: nextcloud-ingress.yml
namePrefix: 'nordunet-'
lasse commented 2025-02-17 10:54:35 +00:00
Owner
Copy link

Jag är inte säker på att nameprefix är en bra idé. Alla resurser skapas ju i separata namespaces för varje kund, så det blir lite redundant.

Jag är inte säker på att nameprefix är en bra idé. Alla resurser skapas ju i separata namespaces för varje kund, så det blir lite redundant.
lasse marked this conversation as resolved
lasse added 1 commit 2025-02-18 07:52:20 +00:00
lasse added 1 commit 2025-02-18 07:54:10 +00:00
lasse added 1 commit 2025-02-18 08:04:11 +00:00
lasse merged commit 3998b7417a into main 2025-02-18 08:11:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lasse
Micke
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Drive/k8s-manifests#1
No description provided.
Delete branch "richir-more-labb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?