Commit graph

3528 commits

Author SHA1 Message Date
Daniel Hoffend
18882d02dd Don't accept invalid yubikey tokens
Summary: Don't accept empty/invalid yubikey token input when adding a factor

Test Plan: Use empty yubikey field or token < 12 chars

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Reviewed By: #roundcube_kolab_plugins_developers, mollekopf

Subscribers: #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D375
2023-09-21 15:35:21 +02:00
Aleksander Machniak
1ee5a5fa0e Use HTTPS URL in "This is a Kolab Groupware object [...]" text
Summary: In 2018 it should be save to use HTTPS in such a URL, given that HTTPS is unlikely to go away.

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Reviewed By: #roundcube_kolab_plugins_developers, mollekopf

Tags: #roundcube

Differential Revision: https://git.kolab.org/D647
2023-09-21 15:33:33 +02:00
Aleksander Machniak
83e4a3b92b Fix PHP8 warning 2023-08-09 15:25:21 +02:00
Aleksander Machniak
1818ee06c9 Fix PHP8 warnings 2023-08-09 13:31:53 +02:00
Aleksander Machniak
4f2fcfce96 Fix PHP8 warnings 2023-08-07 16:16:24 +02:00
Aleksander Machniak
a1de0c679b Fix PHP8 warnings 2023-08-07 15:00:13 +02:00
Aleksander Machniak
99717b0877 Calendar: Fix restoring an event (or event occurrence) in the Kolab driver (T854626) 2023-08-03 14:12:27 +02:00
Aleksander Machniak
57ed29ef68 Fix PHP8 warning 2023-08-02 16:03:38 +02:00
Aleksander Machniak
36d8b80300 Don't "inherit" free_busy flag from the iTip invitation 2023-08-01 15:57:18 +02:00
Aleksander Machniak
5d28225264 Fix PHP8 warning 2023-08-01 15:34:33 +02:00
Aleksander Machniak
1b212f3ee2 Fix PHP8 warnings 2023-08-01 10:47:02 +02:00
Aleksander Machniak
83fd802cc4 Fix PHP8 warnings 2023-07-28 14:07:18 +02:00
Christian Mollekopf
fa7f7324e8 Reset the status on mail_message_load so we can process multiple
messages

Otherwise we just keep returning the data from the first parse in
get_mail_ical_objects.
2023-07-27 11:47:26 +02:00
Christian Mollekopf
5a8b8c5e74 php8 warnings 2023-07-27 09:19:19 +02:00
Aleksander Machniak
c350c1ebbf Fix issues in the Delegate Invitation dialog 2023-07-24 11:10:46 +02:00
Christian Mollekopf
2172ad293f php8 warnings 2023-07-24 10:13:18 +02:00
Aleksander Machniak
79db2b2c45 Add 'calendar_rsvp_actions' option 2023-07-21 19:22:27 +02:00
Aleksander Machniak
dae51e28a1 Fix PHP8 warning 2023-07-13 12:27:07 +02:00
Aleksander Machniak
83d5c9f7f5 Fix handling of kolab_freebusy_server=false (and other empty values)
- Cleanup code
- Hide availability features in the Resources tab
2023-06-23 14:38:10 +02:00
Aleksander Machniak
5863bcc947 Fix PHP8 warnings 2023-06-23 13:15:51 +02:00
Aleksander Machniak
e72b765d20 Fix PHP8 warning 2023-06-23 13:08:42 +02:00
Aleksander Machniak
b7dc093954 DAV: Don't consider addressbooks to be calendars (T7276) 2023-06-20 14:46:01 +02:00
Aleksander Machniak
84ef4ac9e3 Fix folders discovery on non-kolab DAV servers (T7276) 2023-06-20 14:31:10 +02:00
Aleksander Machniak
5fcf64fd9f PHP8 compatibility fixes (T7241) 2023-06-16 11:36:22 +02:00
Aleksander Machniak
7f764413f6 kolab_2fa: Bump min PHP version to >= 7.2.0 2023-06-15 14:30:32 +02:00
Aleksander Machniak
4ff91e51de Fix PHP8 warning 2023-06-15 14:03:15 +02:00
Aleksander Machniak
70810e1f88 kolab_2fa: Bump spomky-labs/otphp to version 10
Fixes various PHP8 warnings
2023-06-15 12:26:53 +02:00
Aleksander Machniak
84f10a366b Fix PHP8 warnings 2023-06-14 15:10:51 +02:00
Aleksander Machniak
8430605f6c Fix PHP8 warnings 2023-06-14 15:05:00 +02:00
Christoph Erhardt
32f1865339 Fix TOTP authentication
Summary:
Kolab used to depend on version 4 of the otphp library, which returns
its computed OTP codes as integers. Hence, the kolab_2fa plugin converts
the user input to `int` in order to facilitate comparisons using the
`===` operator.

Starting with version 5, which is now bundled with Kolab, otphp returns
a string instead of an integer. Now the comparison is between an `int`
and a `string`, and thus consistently yields `false`. As a result, no
TOTP code is ever accepted.

Fix TOTP authentication by removing the now-obsolete conversion to
`int`.

Reviewers: machniak

Reviewed By: machniak

Differential Revision: https://git.kolab.org/D4370
2023-06-14 14:54:18 +02:00
Aleksander Machniak
096b7a8181 Fix PHP8 warnings 2023-06-12 12:07:58 +02:00
Aleksander Machniak
6841eb8207 Fix constant name (LOG_EMERGE -> LOG_EMERG) 2023-06-10 09:25:55 +02:00
Aleksander Machniak
4a15d64a69 Fix PHP fatal error 2023-06-08 11:27:15 +02:00
Aleksander Machniak
609336d71f Fix PHP8 warnings 2023-06-06 14:52:01 +02:00
Aleksander Machniak
2b29e447ba Fix PHP8 warnings 2023-06-02 13:48:23 +02:00
Aleksander Machniak
a8a78d3f66 Fix regression on addressbook and notes lists (T7463) 2023-06-02 12:20:06 +02:00
Aleksander Machniak
f4a9b1759b Re-add localization labels removed unintentionally by transifex pull 2023-06-02 09:03:20 +02:00
Aleksander Machniak
4413130c52 Fix PHP warning 2023-06-01 10:18:11 +02:00
Christian Mollekopf
c3de38d72f Bumping http_request from 2.3 to 2.5 for kolab_sso 2023-05-30 09:20:05 +02:00
Aleksander Machniak
66226d6251 Fix typo in localization label 2023-05-26 10:23:49 +02:00
Aleksander Machniak
84084ff3ab Prevent error when using nextcloud_link plugin in CLI 2023-05-11 14:45:22 +02:00
Aleksander Machniak
8d688a4189 Fix email address case-sensitivity in a few places 2023-05-10 15:20:50 +02:00
Aleksander Machniak
0bbc11858a By default subscribe to new non-mail folders 2023-05-05 08:54:58 +02:00
Aleksander Machniak
f70c6d3508 Fix cache issue with handling more than 500 records 2023-05-03 10:31:53 +02:00
Christian Mollekopf
d711a32fab php8 fixes 2023-05-03 09:40:46 +02:00
Christian Mollekopf
f3592eaf3b Always fetch the full result in kolab_storage_cache::select
The previous behaviour did not work in the addressbook if more than 500
results were provided, because nothing turned the uid only fetch into
the full data, resulting in "empty" result records.
This solution seems to work fine for the cases tested and avoids having
to completely different codepaths based on a number of records found.
2023-05-03 09:25:49 +02:00
Aleksander Machniak
68eaf60aca Fix moving objects between DAV folders
The code does "move object then read it" and "read it" was failing
because the folder cache wasn't up-to-date. We force re-synchronization
by reseting the state properly after move().
2023-05-01 12:11:33 +02:00
Aleksander Machniak
000cfa43b5 Fix syntax of SQL queries for the caldav driver in Calendar 2023-04-28 10:46:21 +02:00
Christian Mollekopf
3daf72a5d5 Revert tasklist driver default change 2023-04-21 15:08:42 +02:00
Christian Mollekopf
5a833866c7 Fixed display of folders in activesync ui
An empty array is expected, we just need to check if the key exists.
2023-04-20 10:24:46 +02:00