Commit graph

3611 commits

Author SHA1 Message Date
Aleksander Machniak
1072c6303f Bump version numbers, cleanup composer.json files
Summary:
The idea is to make a tag and update the public Roundcube mirrors
so a wider audience can use the plugins.

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Reviewed By: #roundcube_kolab_plugins_developers, mollekopf

Subscribers: #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D5100
2025-02-27 15:45:26 +01:00
Aleksander Machniak
0d455af280 2FA: Use 32-char (160bit) long secrets
Summary: Also fix logger, so it does not log anything by default

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Reviewed By: #roundcube_kolab_plugins_developers, mollekopf

Subscribers: #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D5118
2025-02-27 15:43:53 +01:00
Christian Mollekopf
32899fc406 Skip null values in fixprefs.sh 2025-02-25 15:39:57 +01:00
Christian Mollekopf
f3a19e0a43 Generate a 32 character long totp secret
This provides 160bit length instead of the previous 80, as
recommended by the rfc4226 (hotp), which is the basis for rfc6238 (totp).
128 bit is required by the rfc, and e.g. FreeOTP complains with an 80bit secret.
2025-02-25 12:53:26 +01:00
Aleksander Machniak
12787ff4c2 Tags: Fix removing tags from messages list on tag delete from a mail preview window 2025-01-06 12:59:58 +01:00
Aleksander Machniak
b3e686c00a Fix PHP warning 2025-01-06 12:20:34 +01:00
Aleksander Machniak
21ead0149e Kolab Tags SQL and ANNOTATE drivers
Summary:
The implementation in the SQL driver sub-optimal as it uses the same member format and internal API as the Kolab driver.
We might need to improve this.

Requires b206cbc87a and a34f716051

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Subscribers: mollekopf, #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D5032
2024-12-24 09:00:30 +01:00
Aleksander Machniak
687ab45110 CS fixes 2024-11-22 10:57:14 +01:00
Aleksander Machniak
8a7b4e2497 Don't use is_resource() on LDAP connection object (PHP >= 8.1) 2024-10-27 08:38:17 +01:00
Aleksander Machniak
f3761f1d02 Fix displaying calendar alarms 2024-09-27 09:53:30 +02:00
Aleksander Machniak
bca2a7d314 kolab_2fa: Add preferences migration script 2024-09-12 15:18:30 +02:00
Aleksander Machniak
bb8710a747 kolab_2fa: Fix so removed factors are removed for real 2024-09-12 13:32:08 +02:00
Aleksander Machniak
b848f85360 kolab_2fa: Disable 2FA in SSO mode on Roundcube > 1.6 2024-09-12 09:56:52 +02:00
Aleksander Machniak
a2119c58f6 kolab_2fa: Store driver config with the "token"
This way if we change the configuration registered OTP apps will still work.
2024-09-06 12:39:58 +02:00
Aleksander Machniak
3d54dae3e6 kolab_2fa: Fix compatibility with OTP apps that require algorithm in upper-case 2024-09-03 15:40:32 +02:00
Aleksander Machniak
ccc000f219 Fix Uncaught TypeError: date(): Argument #2 ($timestamp) must be of type ?int, string given (PHP 8.4) 2024-08-30 20:09:32 +02:00
Aleksander Machniak
0e78f492fe Fix PHP 8.4 deprecation warning 2024-08-30 20:05:11 +02:00
Aleksander Machniak
79756d53df DAV: Single-type calendar and tasks folders
Summary:
- Don't store tasks and events in the same folder, set new folder supported-calendar-component-set appropriately
- Make single request on folder creation. Before it was MKCOL + PROPPATCH, now it's MKCOL

Test Plan: Create Tasks folder, check it does not appear in Calendar, and vice-versa

Reviewers: #roundcube_developers, mollekopf

Reviewed By: #roundcube_developers, mollekopf

Subscribers: #roundcube_developers

Differential Revision: https://git.kolab.org/D4656
2024-08-29 15:41:19 +02:00
Aleksander Machniak
102847604d Fix PHP8 warnings 2024-07-23 11:19:50 +02:00
Christian Mollekopf
cfd8b4e6c8 php8 warning 2024-07-04 11:13:47 +02:00
Aleksander Machniak
398c3120e8 Add missing test file 2024-07-02 12:24:52 +02:00
Aleksander Machniak
8f88b4b120 Fix fatal error when parsing VEVENT without DTSTART
Such a dummy/redundant VEVENT block was found in an iTip created in Exchange 2010.
2024-07-02 12:21:09 +02:00
Aleksander Machniak
1345402bb9 Fix tests using Roundcube master 2024-07-02 11:50:10 +02:00
Aleksander Machniak
905644dc6c Default DAV folder detection 2024-05-30 08:34:32 +02:00
Aleksander Machniak
2cedf86201 Log error and do not throw when an iTip body is unset 2024-05-23 15:29:27 +02:00
Aleksander Machniak
6575f26900 Fix phpstan error 2024-05-23 15:25:01 +02:00
Aleksander Machniak
98e2dc3db8 Fix potential XSS issue 2024-05-17 14:19:22 +02:00
Christian Mollekopf
53b866e98f php8 warning 2024-05-08 09:39:11 +02:00
Christian Mollekopf
dcf4c8aeda Detect errors on fetch_headers
The search can be too long on dovecot, but we never notice because
fetch_headers doesn't distinguish between error and empty result.
We shouldn't normally get an empty result though, so this should work.
2024-05-08 09:24:27 +02:00
Aleksander Machniak
08ede7da0e Fix PHP8 warnings 2024-04-26 11:22:13 +02:00
Aleksander Machniak
fca13da536 Pending invitations calendars for CalDAV 2024-04-26 11:17:56 +02:00
Aleksander Machniak
f96251e003 Update activesync_setup_url 2024-04-18 15:25:18 +02:00
Aleksander Machniak
ed50d5fc58 T8358: Fix DAV folder owner encoding 2024-04-18 15:09:51 +02:00
Aleksander Machniak
95cc2eb973 Ignore some errors in stderr in some tests 2024-04-18 14:03:46 +02:00
Aleksander Machniak
4f8869529e Fix fatal error when parsing an event with broken recurrence 2024-04-18 13:53:13 +02:00
Aleksander Machniak
cbc8078c79 Fix more phpstan code issues 2024-04-16 08:58:06 +02:00
Christian Mollekopf
8705d6d994 php8 compat 2024-04-12 10:57:41 +02:00
Christian Mollekopf
817fbf738c Static properties cannot be accessed via the object operator
https://www.php.net/manual/en/language.oop5.static.php

Fixes:
Undefined property: kolab_storage::$last_error in /usr/share/roundcubemail/plugins/calendar/drivers/kolab/kolab_driver.php on line 397
2024-04-12 10:57:41 +02:00
Aleksander Machniak
0333d78048 Fix phpstan error 2024-04-04 16:14:10 +02:00
Christian Mollekopf
62ef0c0c2e event can be null if parsing failed
Summary:
According to:
[01-Apr-2024 09:20:33 UTC] PHP Warning:  Trying to access array offset on value of type null in /usr/share/roundcubemail/plugins/calendar/calendar.php on line 3648

Differential Revision: https://git.kolab.org/D4677
2024-04-04 12:07:33 +02:00
Aleksander Machniak
5786172154 ACL management for DAV folders
Summary:
Implement DAV folder sharing based on draft-pot-webdav-resource-sharing standard

We keep the DAV ACL standard implementation as an option, but this standard
does not cover the folder discovery, so we'll not use it with Kolab setups.

Reviewers: #roundcube_kolab_plugins_developers

Subscribers: #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D4668
2024-04-02 15:46:33 +02:00
Aleksander Machniak
00bc00945b Fix bug in mail_get_itip_object()
This could cause problems with accepting iTip invitations.
2024-03-28 20:35:51 +01:00
Christian Mollekopf
1ecff64896 Restore php 7.2 compat
??= is apparently only available from 7.4 on.

See:
https://wiki.php.net/rfc/null_coalesce_equal_operator
2024-03-26 12:49:45 +01:00
Christian Mollekopf
d19de72637 Apparently we can get 200 without a body back 2024-03-25 13:44:00 +01:00
Christian Mollekopf
4e0b7df3ca Relax caxy/php-htmldiff requirement
0.1.9 is the last version with php 7.2 support
2024-03-13 11:02:26 +01:00
Aleksander Machniak
f2547d87fe tasklist: Fix various issues with DAV driver, store alarms option in folder properties 2024-02-29 16:23:57 +01:00
Aleksander Machniak
7d2672fba7 Tasklist: Fix unwanted tag creation when flagging a task 2024-02-28 13:10:22 +01:00
Aleksander Machniak
d3c0b28196 PHPDoc updates 2024-02-28 13:07:38 +01:00
Aleksander Machniak
84c232f6dc Fix PHP Fatal error: Cannot access private property kolab_ldap::$ready 2024-02-28 12:42:49 +01:00
Aleksander Machniak
b472372a80 Fix editing addressbook folder using Kolab driver 2024-02-12 12:57:25 +01:00