Micke/roundcubemail-plugins-kolab
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent from creating empty objects

Browse source
This commit is contained in:
Aleksander Machniak 2019-09-29 10:03:00 +00:00
parent dac422ef97
commit e0b593ba52
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/libkolab/lib/kolab_storage_folder.php
View file

@ -594,7 +594,7 @@ class kolab_storage_folder extends kolab_storage_folder_api
*/ */
public function save(&$object, $type = null, $uid = null) public function save(&$object, $type = null, $uid = null)
{ {
if (!$this->valid) { if (!$this->valid && empty($object)) {
return false; return false;
} }

6
plugins/libkolab/tests/kolab_storage_folder.php
View file

@ -177,6 +177,11 @@ class kolab_storage_folder_test extends PHPUnit_Framework_TestCase
$this->markTestSkipped('No Kolab support'); $this->markTestSkipped('No Kolab support');
} }
$folder = new kolab_storage_folder('Contacts', 'contact');
$saved = $folder->save(null, 'contact');
$this->assertFalse($saved);
$contact = array( $contact = array(
'name' => 'FN', 'name' => 'FN',
'surname' => 'Last', 'surname' => 'Last',
@ -187,7 +192,6 @@ class kolab_storage_folder_test extends PHPUnit_Framework_TestCase
'organization' => 'Company A.G.' 'organization' => 'Company A.G.'
); );
$folder = new kolab_storage_folder('Contacts', 'contact');
$saved = $folder->save($contact, 'contact'); $saved = $folder->save($contact, 'contact');
$this->assertTrue((bool)$saved); $this->assertTrue((bool)$saved);
} }