From 315079c8e41c25da93bbfe8b3fe19cc7698b6282 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Mon, 7 Jan 2019 13:04:55 +0000 Subject: [PATCH] Fix bug where hidden ldap addressbooks would still be visible (Bifrost#T171965) --- plugins/kolab_addressbook/kolab_addressbook.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/kolab_addressbook/kolab_addressbook.php b/plugins/kolab_addressbook/kolab_addressbook.php index 2ddf8db2..37178d0f 100644 --- a/plugins/kolab_addressbook/kolab_addressbook.php +++ b/plugins/kolab_addressbook/kolab_addressbook.php @@ -204,8 +204,9 @@ class kolab_addressbook extends rcube_plugin $jsdata = array(); $sources = (array)$this->rc->get_address_sources(); - // list all non-kolab sources first - foreach (array_filter($sources, function($source){ return empty($source['kolab']); }) as $j => $source) { + // list all non-kolab sources first (also exclude hidden sources) + $filter = function($source){ return empty($source['kolab']) && empty($source['hidden']); }; + foreach (array_filter($sources, $filter) as $j => $source) { $id = strval(strlen($source['id']) ? $source['id'] : $j); $out .= $this->addressbook_list_item($id, $source, $jsdata) . ''; }