Micke/roundcubemail-plugins-kolab
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iCal parsing can consume high memory when file contains lots of events. Abort import if memory is expected to get exhausted (#2353)

Browse source
This commit is contained in:
Thomas Bruederli 2013-10-16 12:46:13 +02:00
parent dae0af24cd
commit 1f851a7663
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plugins/libcalendaring/libvcalendar.php
View file

@ -113,6 +113,15 @@ class libvcalendar
// TODO: convert charset to UTF-8 if other // TODO: convert charset to UTF-8 if other
try { try {
// estimate the memory usage and try to avoid fatal errors when allowed memory gets exhausted
$count = substr_count($vcal, 'BEGIN:VEVENT');
$memory_available = parse_bytes(ini_get('memory_limit')) - (function_exists('memory_get_usage') ? memory_get_usage() : 16*1024*1024);
$expected_memory = $count * 70*1024; // assume ~ 70K per event (empirically determined)
if ($memory_available > 0 && $expected_memory > $memory_available) {
throw new Exception("iCal file too big");
}
$vobject = VObject\Reader::read($vcal, VObject\Reader::OPTION_FORGIVING | VObject\Reader::OPTION_IGNORE_INVALID_LINES); $vobject = VObject\Reader::read($vcal, VObject\Reader::OPTION_FORGIVING | VObject\Reader::OPTION_IGNORE_INVALID_LINES);
if ($vobject) if ($vobject)
return $this->import_from_vobject($vobject); return $this->import_from_vobject($vobject);