Commit graph

56 commits

Author SHA1 Message Date
Daniel Hoffend
18882d02dd Don't accept invalid yubikey tokens
Summary: Don't accept empty/invalid yubikey token input when adding a factor

Test Plan: Use empty yubikey field or token < 12 chars

Reviewers: #roundcube_kolab_plugins_developers, mollekopf

Reviewed By: #roundcube_kolab_plugins_developers, mollekopf

Subscribers: #roundcube_kolab_plugins_developers

Differential Revision: https://git.kolab.org/D375
2023-09-21 15:35:21 +02:00
Aleksander Machniak
7f764413f6 kolab_2fa: Bump min PHP version to >= 7.2.0 2023-06-15 14:30:32 +02:00
Aleksander Machniak
4ff91e51de Fix PHP8 warning 2023-06-15 14:03:15 +02:00
Aleksander Machniak
70810e1f88 kolab_2fa: Bump spomky-labs/otphp to version 10
Fixes various PHP8 warnings
2023-06-15 12:26:53 +02:00
Aleksander Machniak
84f10a366b Fix PHP8 warnings 2023-06-14 15:10:51 +02:00
Aleksander Machniak
8430605f6c Fix PHP8 warnings 2023-06-14 15:05:00 +02:00
Christoph Erhardt
32f1865339 Fix TOTP authentication
Summary:
Kolab used to depend on version 4 of the otphp library, which returns
its computed OTP codes as integers. Hence, the kolab_2fa plugin converts
the user input to `int` in order to facilitate comparisons using the
`===` operator.

Starting with version 5, which is now bundled with Kolab, otphp returns
a string instead of an integer. Now the comparison is between an `int`
and a `string`, and thus consistently yields `false`. As a result, no
TOTP code is ever accepted.

Fix TOTP authentication by removing the now-obsolete conversion to
`int`.

Reviewers: machniak

Reviewed By: machniak

Differential Revision: https://git.kolab.org/D4370
2023-06-14 14:54:18 +02:00
Aleksander Machniak
096b7a8181 Fix PHP8 warnings 2023-06-12 12:07:58 +02:00
Aleksander Machniak
6841eb8207 Fix constant name (LOG_EMERGE -> LOG_EMERG) 2023-06-10 09:25:55 +02:00
Aleksander Machniak
b3c882e037 Add tests for the localization files 2022-12-01 12:42:11 +01:00
Jeroen van Meeuwen (Kolab Systems)
dc99ade020 Bump version numbers to 3.5.11 2022-01-14 13:18:46 +01:00
Aleksander Machniak
2dc22ac017 kolab_2fa: Allow kolab_auth'enticated admins to change user's 2FA settings (add/remove factors) 2021-12-21 11:01:41 +01:00
Jeroen van Meeuwen (Kolab Systems)
c1d3e1dbde Bump version 2021-10-01 13:20:35 +02:00
Aleksander Machniak
945ac3605d Fix 2FA logon with kolab_auth's "login as" feature 2021-07-02 13:55:17 +02:00
Aleksander Machniak
5a94fd8bc6 2FA: Add missing login_lc config handling
Fixes 2FA bypass by using upper-case letter in the username
2021-06-08 10:37:26 +02:00
Jeroen van Meeuwen (Kolab Systems)
9a13a39e7f Bump version numbers to 3.5.6 2021-04-12 12:04:40 +02:00
Aleksander Machniak
2129b4e2c0 Fix PHP warnings 2021-03-08 14:29:23 +01:00
Jeroen van Meeuwen (Kolab Systems)
4760d1a3d5 Bump version number 2019-10-19 11:55:22 +02:00
Aleksander Machniak
7491bf813c Update localization (again) 2019-10-13 15:55:15 +02:00
Aleksander Machniak
a4776ffcc8 Update localization, fix counting translation lines in update script 2019-10-13 14:54:56 +02:00
Jeroen van Meeuwen (Kolab Systems)
43d2b00e96 Bump version to 3.5.0 2019-07-08 12:57:20 +02:00
Aleksander Machniak
9da21b887c CS fixes, updates to composer.json files 2019-06-12 08:32:26 +00:00
Jeroen van Meeuwen (Kolab Systems)
e0d11833a1 Bump version numbers 2019-05-07 08:32:27 +02:00
Aleksander Machniak
290adfbbb1 Merge branch 'dev/elastic' 2019-05-06 08:30:23 +02:00
Jeroen van Meeuwen (Kolab Systems)
4ad016bce4 Bump versions to 3.4.4 2019-04-15 11:04:06 +02:00
Aleksander Machniak
f31c329ca7 Fix button selectors (.ui-button -> button)
Buttons in Elastic dialogs do not have this class assigned. We also
will get rid of jQuery-UI button use in the future.
2019-04-08 10:35:45 +02:00
Aleksander Machniak
e13bdd55a7 Elastic: Catch up with layout refactoring in core 2019-03-25 12:27:51 +01:00
Aleksander Machniak
c1f1c9daed Use https:// for plugins.roundcube.net 2019-01-23 08:17:36 +01:00
Jeroen van Meeuwen (Kolab Systems)
56a4693914 Update German translations by using de sources and de_DE sources for de_DE translations 2018-12-19 10:25:52 +01:00
Jeroen van Meeuwen (Kolab Systems)
ac7b742005 Update the base translations before merge 2018-12-19 10:25:52 +01:00
Jeroen van Meeuwen (Kolab Systems)
37b89deb34 Bump version numbers to 3.4.1 2018-12-06 11:09:09 +01:00
Aleksander Machniak
db27d5a26c Register kolab_2fa and kolab_sso localizations in /tx/config 2018-12-04 12:53:29 +01:00
Jeroen van Meeuwen (Kolab Systems)
89a7362058 Bump plugin versions and requirements 2018-04-09 12:23:01 +02:00
Aleksander Machniak
cc15a0c0db Remove redundant argument of include_stylesheet() 2018-01-25 13:23:26 +01:00
Aleksander Machniak
a3a1691cde Elastic skin support for kolab_2fa 2017-11-06 12:34:59 +01:00
Aleksander Machniak
fe64e470c8 Initial Elastic skin support for kolab_delegation and kolab_activesync plugins 2017-11-03 11:43:31 +01:00
Jeroen van Meeuwen (Kolab Systems)
915b86bb80 Bump versions to 3.3.4 2017-10-02 12:59:58 +02:00
Aleksander Machniak
f48823ae62 Default timeout is 120 2017-09-29 12:06:49 +02:00
Aleksander Machniak
7c81d3f1dd T606: Fix refreshing list of auth factors after adding/removing them 2017-09-27 13:38:23 +02:00
Jeroen van Meeuwen (Kolab Systems)
f30978e288 Set the version to 3.3.0 2017-05-03 10:08:25 +02:00
Thomas Bruederli
db2d3bc800 Fix driver initialization with config properties for the right method (T1784)
Summary:
Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Reviewers: machniak

Reviewed By: machniak

Subscribers: jh23453

Differential Revision: https://git.kolab.org/D242
2016-11-09 09:55:34 +01:00
Aleksander Machniak
669feb6b02 Comment out console() calls, CS fixes 2016-01-28 17:12:23 +01:00
Aleksander Machniak
f1eada2be3 Fix "Failed to save authentication token" when adding token to kolab-2fa plugin (T968) 2016-01-28 17:07:11 +01:00
Thomas Bruederli
bbddeb6345 Replace stubs with actual implementation which was missing in the repo
Resolves T595
2015-07-06 22:37:45 +02:00
Jeroen van Meeuwen (Kolab Systems)
c7e0545e85 Workaround T595 2015-07-06 16:47:33 +02:00
Jeroen van Meeuwen (Kolab Systems)
d535d137e5 Fix TOTP (Resolves T603) 2015-07-06 16:32:34 +02:00
Thomas Bruederli
0a24a09a73 Add logging facilities for Storage classes as requested by T469. Not finished yet... 2015-06-14 17:17:08 +02:00
Thomas Bruederli
9cd117d7a2 Add README for kolab_2fa plugin 2015-06-11 17:48:36 +02:00
Thomas Bruederli
f19f3f06c1 Require 2nd factor verification for adding an new factor 2015-06-11 17:16:46 +02:00
Thomas Bruederli
3e52521c3e Finished LDAP storage backend to work with FreeIPA ipaToken subclasses
Resolves T421
2015-06-11 16:38:47 +02:00