Drive/roundcubemail-plugins-kolab
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always fetch the full result in kolab_storage_cache::select

Browse source 
The previous behaviour did not work in the addressbook if more than 500
results were provided, because nothing turned the uid only fetch into
the full data, resulting in "empty" result records.
This solution seems to work fine for the cases tested and avoids having
to completely different codepaths based on a number of records found.
This commit is contained in:
Christian Mollekopf 2023-05-03 09:25:49 +02:00
parent 68eaf60aca
commit f3592eaf3b
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
plugins/libkolab/lib/kolab_storage_cache.php
View file

@ -25,7 +25,6 @@
class kolab_storage_cache
{
const DB_DATE_FORMAT = 'Y-m-d H:i:s';
const MAX_RECORDS = 500;
protected $db;
protected $imap;
@ -778,8 +777,8 @@ class kolab_storage_cache
if ($this->ready) {
$this->_read_folder_data();
// fetch full object data on one query if a small result set is expected
$fetchall = !$uids && ($this->limit ? $this->limit[0] : ($count = $this->count($query))) < self::MAX_RECORDS;
// fetch full object data unless only uids are requested
$fetchall = !$uids;
// skip SELECT if we know it will return nothing
if ($count === 0) {