From 83951483f97fbc155122e0773d50306e02e96b9c Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <machniak@kolabsys.com>
Date: Sat, 24 Oct 2015 19:52:03 +0200
Subject: [PATCH] Fix javascript error when selecting a contact in search
 result (#5269)

---
 .../kolab_addressbook/kolab_addressbook.js    | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/plugins/kolab_addressbook/kolab_addressbook.js b/plugins/kolab_addressbook/kolab_addressbook.js
index ea2494c5..6962e701 100644
--- a/plugins/kolab_addressbook/kolab_addressbook.js
+++ b/plugins/kolab_addressbook/kolab_addressbook.js
@@ -146,11 +146,20 @@ if (window.rcmail) {
     // wait until rcmail.contact_list is ready and subscribe to 'select' events
     setTimeout(function() {
         rcmail.contact_list && rcmail.contact_list.addEventListener('select', function(list) {
-            var selected = list.selection.length,
-                source = rcmail.env.source ? rcmail.env.address_sources[rcmail.env.source] : null;
+            var source, is_writable = true;
 
-            if (selected && source.kolab) {
-                rcmail.enable_command('delete', 'move', selected && source.rights.indexOf('t') >= 0);
+            // delete/move commands status was set by Roundcube core,
+            // however, for Kolab addressbooks we like to check folder ACL
+            if (list.selection.length && rcmail.commands['delete']) {
+                for (n in rcmail.env.selection_sources) {
+                    source = rcmail.env.address_sources[n];
+                    if (source && source.kolab && source.rights.indexOf('t') < 0) {
+                        is_writable = false;
+                        break;
+                    }
+                }
+
+                rcmail.enable_command('delete', 'move', is_writable);
             }
         });
     }, 100);
@@ -160,9 +169,9 @@ if (window.rcmail) {
 rcube_webmail.prototype.set_book_actions = function()
 {
     var source = !this.env.group ? this.env.source : null,
-        sources = this.env.address_sources || {};
+        sources = this.env.address_sources || {},
+        props = source && sources[source] && sources[source].kolab ? sources[source] : { removable: false, rights: '' };
 
-    var props = source && sources[source] && sources[source].kolab ? sources[source] : { removable: false, rights: '' }
     this.enable_command('book-create', true);
     this.enable_command('book-edit',   props.rights.indexOf('a') >= 0);
     this.enable_command('book-delete', props.rights.indexOf('x') >= 0 || props.rights.indexOf('a') >= 0);