Drive/roundcubemail-plugins-kolab
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Performance: Skip one SELECT query when deleting relations

Browse source
This commit is contained in:
Aleksander Machniak 2016-02-22 15:37:12 +01:00
parent 2a9948b827
commit 644df15bad
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
plugins/libkolab/lib/kolab_storage_config.php
View file

@ -211,25 +211,27 @@ class kolab_storage_config
/** /**
* Remove configuration object * Remove configuration object
* *
* @param string $uid Object UID * @param string|array $object Object array or its UID
* *
* @return bool True on success, False on failure * @return bool True on success, False on failure
*/ */
public function delete($uid) public function delete($object)
{ {
if (!$this->is_enabled()) { if (!$this->is_enabled()) {
return false; return false;
} }
// fetch the object to find folder // fetch the object to find folder
$object = $this->get_object($uid); if (!is_array($object)) {
$object = $this->get_object($object);
}
if (!$object) { if (!$object) {
return false; return false;
} }
$folder = $this->find_folder($object); $folder = $this->find_folder($object);
$status = $folder->delete($uid); $status = $folder->delete($object);
// on success, update cached tags list // on success, update cached tags list
if ($status && is_array($this->tags)) { if ($status && is_array($this->tags)) {
@ -846,7 +848,7 @@ class kolab_storage_config
// remove relation if no other members remain // remove relation if no other members remain
if (count($members) <= 1) { if (count($members) <= 1) {
$done = $this->delete($relation['uid']); $done = $this->delete($relation);
} }
// update relation object if members changed // update relation object if members changed
else if (count(array_diff($members, $relation['members'])) || count(array_diff($relation['members'], $members))) { else if (count(array_diff($members, $relation['members'])) || count(array_diff($relation['members'], $members))) {