Better process of writing Kolab objects: don't use isValid() but check kolabformat::error() after writing. Fixes #769

plugins/libkolab/lib/kolab_format.php

@@ -158,6 +158,40 @@ abstract class kolab_format
         return $vec;
     }
 
+    /**
+     * Check for format errors after calling kolabformat::write*()
+     *
+     * @return boolean True if there were errors, False if OK
+     */
+    protected function format_errors()
+    {
+        $ret = $log = false;
+        switch (kolabformat::error()) {
+            case kolabformat.NoError:
+                $ret = false;
+                break;
+            case kolabformat.Warning:
+                $ret = false;
+                $log = "Warning";
+                break;
+            default:
+                $ret = true;
+                $log = "Error";
+        }
+
+        if ($log) {
+            raise_error(array(
+                'code' => 660,
+                'type' => 'php',
+                'file' => __FILE__,
+                'line' => __LINE__,
+                'message' => "kolabformat write $log: " . kolabformat::errorMessage(),
+            ), true);
+        }
+
+        return $ret;
+    }
+
     /**
      * Save the last generated UID to the object properties.
      * Should be called after kolabformat::writeXXXX();

plugins/libkolab/lib/kolab_format_contact.php

@@ -132,11 +132,12 @@ class kolab_format_contact extends kolab_format
     public function write()
     {
         $this->init();
-
-        if ($this->obj->isValid()) {
         $this->xmldata = kolabformat::writeContact($this->obj);
+
+        if (!parent::format_errors())
             parent::update_uid();
-        }
+        else
+            $this->xmldata = null;
 
         return $this->xmldata;
     }

plugins/libkolab/lib/kolab_format_distributionlist.php

@@ -51,11 +51,12 @@ class kolab_format_distributionlist extends kolab_format
     public function write()
     {
         $this->init();
-
-        if ($this->obj->isValid()) {
         $this->xmldata = kolabformat::writeDistlist($this->obj);
+
+        if (!parent::format_errors())
             parent::update_uid();
-        }
+        else
+            $this->xmldata = null;
 
         return $this->xmldata;
     }

plugins/libkolab/lib/kolab_format_event.php

@@ -116,11 +116,12 @@ class kolab_format_event extends kolab_format
     public function write()
     {
         $this->init();
-
-        if ($this->obj->isValid()) {
         $this->xmldata = kolabformat::writeEvent($this->obj);
+
+        if (!parent::format_errors())
             parent::update_uid();
-        }
+        else
+            $this->xmldata = null;
 
         return $this->xmldata;
     }