Drive/roundcubemail-plugins-kolab
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Performance optimization in contacts search

Browse source 
For cases when the result is smaller than page size we get all contacts
in one query instead of separate selects.
This commit is contained in:
Aleksander Machniak 2018-01-10 11:18:28 +01:00
parent 6c43433e16
commit 51345357d6
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
plugins/kolab_addressbook/lib/rcube_kolab_contacts.php
View file

@ -355,7 +355,7 @@ class rcube_kolab_contacts extends rcube_addressbook
// get members by UID
if (!empty($uids)) {
$this->_fetch_contacts($query = array(array('uid', '=', $uids)), !$fetch_all);
$this->_fetch_contacts($query = array(array('uid', '=', $uids)), $fetch_all ? false : count($uids));
$this->sortindex = array_merge($this->sortindex, $local_sortindex);
}
}
@ -363,7 +363,7 @@ class rcube_kolab_contacts extends rcube_addressbook
$ids = $this->filter['ids'];
if (count($ids)) {
$uids = array_map(array($this, 'id2uid'), $this->filter['ids']);
$this->_fetch_contacts($query = array(array('uid', '=', $uids)), true);
$this->_fetch_contacts($query = array(array('uid', '=', $uids)), count($ids));
}
}
else {
@ -1066,10 +1066,13 @@ class rcube_kolab_contacts extends rcube_addressbook
{
if (!isset($this->dataset) || !empty($query)) {
if ($limit) {
$this->storagefolder->set_order_and_limit($this->_sort_columns(), $this->page_size, ($this->list_page-1) * $this->page_size);
$size = is_int($limit) && $limit < $this->page_size ? $limit : $this->page_size;
$this->storagefolder->set_order_and_limit($this->_sort_columns(), $size, ($this->list_page-1) * $this->page_size);
}
$this->sortindex = array();
$this->dataset = $this->storagefolder->select($query);
$this->dataset = $this->storagefolder->select($query);
foreach ($this->dataset as $idx => $record) {
$contact = $this->_to_rcube_contact($record);
$this->sortindex[$idx] = $this->_sort_string($contact);